ArrayString: Reducing reliance on unsafe blocks + adding some safety comments#288
Open
anforowicz wants to merge 5 commits intobluss:masterfrom
Open
ArrayString: Reducing reliance on unsafe blocks + adding some safety comments#288anforowicz wants to merge 5 commits intobluss:masterfrom
ArrayString: Reducing reliance on unsafe blocks + adding some safety comments#288anforowicz wants to merge 5 commits intobluss:masterfrom
Conversation
Before the changes in `fn new`, the type of `MaybeUninit::uninit()` would be inferred to be `MaybeUninit<[MaybeUninit<...>; CAP]>` which seems somewhat unexpected. This commit rewrites this expression so that no `unsafe` is needed. Similarily, before the changes in `fn zero_filled`, the type of `MaybeUninit::zeroed()` would be inferred to be `MaybeUninit<[MaybeUninit<...>; CAP]>`. This commit also rewrites this expression so that no `unsafe` is needed.
The safe code results in the same, fast assembly code.
The safe code should result in the same, fast assembly code.
This also opportunistically reduces the amount of `unsafe` in `ArrayString::remove`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTAL? Please see the individual commit descriptions for more details.